Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): LogMonitor test fails randomly due to Date.now() #18601

Merged
merged 4 commits into from
Jan 21, 2022
Merged

chore(cli): LogMonitor test fails randomly due to Date.now() #18601

merged 4 commits into from
Jan 21, 2022

Commits on Jan 21, 2022

  1. chore(cli): logs-monitor test fails randomly 

    The logs monitor test was using `Date.now()` which sometimes caused the
actual result to differ from the expected result. Turns out the reason I
needed the dynamic date is because I was generating the timestamp
incorrectly. Fixed that which allowed me to use a hardcoded timestamp.
    @corymhall
    corymhall committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    06b386d View commit details
    Browse the repository at this point in the history

  2. minor change

    @corymhall
    corymhall committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    f1b979c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into corymhall/logsmonitor-test-fix

    @corymhall
    corymhall authored Jan 21, 2022
    Configuration menu
    Copy the full SHA
    42b188c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into corymhall/logsmonitor-test-fix

    @mergify
    mergify[bot] authored Jan 21, 2022
    Configuration menu
    Copy the full SHA
    120d43e View commit details
    Browse the repository at this point in the history