chore(eks): Add missing ami types for node groups

[cgamache]

Adds Windows amiTypes in aws-eks. These are supported via Cloudformation but missing in cdk since the Enum is manually defined.

Closes #24803

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[cgamache]

Clarification Request: I am not able to run integration tests. Please advise how the README should change.

[TheRealAmazonKendra]

Clarification Request: I am not able to run integration tests. Please advise how the README should change.

This should actually be a chore not a feat. Those requirements will disappear.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[cgamache]

Hi @TheRealAmazonKendra ! ... Thanks for the tip from before. The build passed, and it now only lacks an approving review.

[TheRealAmazonKendra]

I'm in agreement with @otaviomacedo here about moving the logic inside InstanceType. While we may have another location that does what you've done here, it's not a great design choice and we should have caught it in that instance as well.

On second glance at this, we actually have more complexity in the logic about which ami's work where so my original comment was wrong in thinking that we didn't need integ tests here. Apologies for not looking closer in the first place and providing misleading information.

Since you mentioned that you aren't able to run integration tests, we'll run them for you. We just need you to write the test cases and we'll run them and update the snapshots.

Pull request has been modified.

[cgamache]

PR updated with requested changes, @TheRealAmazonKendra ... Please let me know if there is anything that I missed.

🤞 this should be ready for integration tests.

[otaviomacedo]

Thanks, @cgamache. Please go ahead and write the integration test cases, so we can generate the snapshots for you.

Pull request has been modified.

[cgamache]

@otaviomacedo @TheRealAmazonKendra Integration test written and added to the PR.

Bad news though-- the build is now failing. I'm not sure if the un-run integration test is the culprit. It builds and unit tests locally without failures.

Nothing looks out of place in the build logs until the failure at the end. And the failure message isn't specific as to what has gone wrong. I do see that it noticed the "NEW" integration test.

Please advise. Thanks very much!

[gitpod-io]

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: f3ef17a
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).