Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CodeArtifact upload fails if no javadocs #25287

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Apr 25, 2023

Don't pass the argument if the javadoc file doesn't exist.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from a team April 25, 2023 11:39
@gitpod-io
Copy link

gitpod-io bot commented Apr 25, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team April 25, 2023 11:39
@github-actions github-actions bot added the p2 label Apr 25, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6c304e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5f6ccee into main Apr 25, 2023
@mergify mergify bot deleted the huijbers/no-javadoc branch April 25, 2023 12:50
@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

madeline-k pushed a commit that referenced this pull request Apr 27, 2023
Don't pass the argument if the javadoc file doesn't exist.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants