fix(cli): diff doesn't display paths for removed resources #25294
Conversation
Even if the old template has paths in it, they are not displayed because all paths are loaded from the assembly metadata. Include the logicalID paths from the old template, if present, but give preference to the new template. This will show paths for removed resources, if there are any. Useful to debug replacements.
|
|
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
rix0rrr
changed the title
rix0rrr
added
pr-linter/cli-integ-tested
aws-cdk-automation
removed
the
pr/needs-cli-test-run
rix0rrr
added
the
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Even if the old template has paths in it, they are not displayed because all paths are loaded from the assembly metadata. Include the logicalID paths from the old template, if present, but give preference to the new template. This will show paths for removed resources, if there are any. Useful to debug replacements. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Even if the old template has paths in it, they are not displayed because all paths are loaded from the assembly metadata.
Include the logicalID paths from the old template, if present, but give preference to the new template.
This will show paths for removed resources, if there are any. Useful to debug replacements.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license