Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(migrate): add integ tests with app deployment #27509

Merged
merged 2 commits into from
Oct 12, 2023
Merged

chore(migrate): add integ tests with app deployment #27509

merged 2 commits into from
Oct 12, 2023

Conversation

TheRealAmazonKendra
Copy link
Contributor

REPLACE THIS TEXT BLOCK

Describe the reason for this change, what the solution is, and any
important design decisions you made.

Remember to follow the CONTRIBUTING GUIDE and DESIGN GUIDELINES for any
code you submit.

Closes #.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 12, 2023 00:19
@github-actions github-actions bot added the p2 label Oct 12, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 12, 2023
@TheRealAmazonKendra
Copy link
Contributor Author

It doesn't think it needs to go through the testing pipeline? Seems wrong. Pushing it through anyway.

@TheRealAmazonKendra TheRealAmazonKendra added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Oct 12, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 12, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9f0448f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@TheRealAmazonKendra TheRealAmazonKendra added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Oct 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1fc5dda into main Oct 12, 2023
19 checks passed
@mergify mergify bot deleted the TheRealAmazonKendra/migrate-tests branch October 12, 2023 06:39
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 12, 2023
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinayak-kukreja vinayak-kukreja vinayak-kukreja approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheRealAmazonKendra @aws-cdk-automation @vinayak-kukreja