Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appconfig-alpha): add deploy method to configuration constructs #28269

Merged
merged 8 commits into from
Dec 6, 2023

Conversation

chenjane-dev
Copy link
Contributor

Adding a deploy method to the configuration construct to allow deployments on a config at any time after creation.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK p2 labels Dec 6, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 6, 2023 01:45
Copy link
Contributor

mergify bot commented Dec 6, 2023

⚠️ The sha of the head commit of this PR conflicts with #28174. Mergify cannot evaluate rules on this PR. ⚠️

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 6, 2023
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Just some minor nits.
Also, can you please close #28174 in favor of this?

@@ -176,6 +176,20 @@ new appconfig.HostedConfiguration(this, 'MyHostedConfiguration', {
});
```

To deploy a configuration to an environment after initialization use the `deployTo` method:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To deploy a configuration to an environment after initialization use the `deployTo` method:
To deploy a configuration to an environment after initialization use the `deploy` method:

const app = new Application(stack, 'MyAppConfig', {
name: 'MyApplication',
});
app.addEnvironment('MyEnv1');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
app.addEnvironment('MyEnv1');

no environment associated

Shouldn't this be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are being attached to the application and not the configuration :)

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 6, 2023
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 6, 2023
@vinayak-kukreja vinayak-kukreja changed the title feat(appconfig): add deploy method to configuration constructs feat(appconfig-alpha): add deploy method to configuration constructs Dec 6, 2023
Copy link
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chenjane-dev , thank you for this contribution.

Copy link
Contributor

mergify bot commented Dec 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 6, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f28e357
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c723ef9 into aws:main Dec 6, 2023
13 checks passed
Copy link
Contributor

mergify bot commented Dec 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@chenjane-dev chenjane-dev deleted the new-deploy-method branch December 6, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants