chore: stop emmitting sourcemaps in integ-tests #29978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/chore/more-resillient-snapshots
branch
from
4016dbf
to
fc81df3
Compare
aws-cdk-automation
added
the
pr/needs-maintainer-review
1 task
colifran
approved these changes
Apr 26, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
…29974) ### Reason for this change There were a number of inconsistencies with the versions used for typescript, jsii & jsii-rosetta in this repository. Also the automated updater was incorrectly updating jsii minor versions. I did some digging and turns out because `jsii` was at `5.4.x` already, we are already using TypeScript 5.4 for most critical paths. So I went ahead and aligned all TS version on that. ### Description of changes Manually align all versions of typescript, jsii & jsii-rosetta. Fixed the update workflow to only update patch version for these three packages. Includes changes from #29978 until that is merged, and this PR is rebased. ### Description of how you validated changes Run through the test pipeline. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Apr 29, 2024
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
While working on a related issue, I noticed that some integ-test snapshots are very brittle because assets include inline sourcemaps and ts files.
Description of changes
With this change, we are disabling all sourcemaps for integ-tests and explicitly exclude ts source files from assets.
This is okay because the handlers are just written to be used inside integ tests.
Another change was made to disable the inline sourcemap for the custom resource handler entrypoint. The actual handlers do not have sourcemaps, so this was silly and probably just an oversight.
Description of how you validated changes
Run integ tests to update snapshots.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license