Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebuild): add missing types for webhook filters #30204

Closed

Conversation

aseppala
Copy link

@aseppala aseppala commented May 15, 2024

Issue

Closes #30062.

Reason for this change

Extends #30064 and adds the requested integration test.

Description of changes

Adds an integration test to test WORKFLOW_JOB_QUEUED GitHub event for a AWS CodeBuild project.

Description of how you validated changes

As I can't authorize my AWS account to create webhooks on aws/aws-cdk Github repository I've executed the new integration test using my own fork of aws/aws-cdk as the source and verified that the test passes. I've then modified the files and patched them to use aws/aws-cdk as the source.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label May 15, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 15, 2024 11:30
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels May 15, 2024
@aseppala aseppala force-pushed the integ-test-codebuild-workflow-job-queued branch from 654e648 to d3c43f2 Compare May 15, 2024 12:30
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 15, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4936d0e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aseppala
Copy link
Author

fyi, @khushail I've opened this PR to address #30062.

super(scope, id);

const source = codebuild.Source.gitHub({
owner: 'aws',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it actually make sense to allow overriding this value to personal fork using an env var (which?) so that non cdk maintainers can run this test?

@garysassano
Copy link

Any ETA for when EventAction.WORKFLOW_JOB_QUEUED will be available in the @aws-cdk-lib/aws-codebuild module?

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jun 23, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(codebuild): Add support new newly introduced event filter
4 participants