-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stepfunctions-tasks): allow passing apiEndpoint as intrinsic function #30954
fix(stepfunctions-tasks): allow passing apiEndpoint as intrinsic function #30954
Conversation
…int instead of string concatenation. This is required when apiEndpoint requires resolving and isn't just plain text. Add unit test to cover passing JsonPath.formatted input. Update integration test. Update (and fix) README entry's usage example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
…destructive changes: "Stack: aws-stepfunctions-tasks-http-invoke-integ - Resource: IntegRestApiDeploymentD67E59EC852098a1c127ca9d7d16d22086273910 - Impact: WILL_DESTROY"
…tpinvoke-allow-endpoint-format
…ion test failure.
Clarification Request |
…tpinvoke-allow-endpoint-format
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
@MathieuGilbert Have you gotten any notice on how to get the build to pass? This PR is relevant to my interests. Good work! |
Thanks @eliasericsson, but no updates yet. I tried opening a discussion question, but no response there either. I'm not sure how to get some actual help 🤷 |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
Closes #29925, #30749
Reason for this change
The
apiEndpoint
prop currently only works when it's a string (ie.TaskInput.fromText('some/text')
), with the task failing when passed as a reference (ie.TaskInput.fromText(JsonPath.format('some/text/{}', '123')
). This is needed to allow for dynamic parts in the path.Description of changes
JsonPath.format
intrinsic function to combine theapiRoot
andapiEndpoint
instead of string concatenation.AWS::ApiGateway::Deployment
to theIntegTest
'sallowDestroy
prop, as updating the integration test led to this build error:Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license