Recommend against JDK8 #400
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CristianPrundeanu
force-pushed
the
jdk8_doc
branch
from
a062333
to
55d7366
Compare
wash-amzn
reviewed
Jul 18, 2024
java.md
Outdated
| @@ -10,6 +10,8 @@ performance benefit until they switched to Java 11. | |||
| This page includes specific details about building and tuning Java application on Graviton. | |||
|
|
|||
| ### Java versions | |||
| If you are still using JDK8, please stronly consider upgrading. There are significant performance improvements that you can benefit from, such as better JIT code generation, optimized GC at high thread counts, Arm-tuned Java monitors and locks, an improved SpinPause logic (with even more options in JDK17, like OnSpinWaitInstCount and OnSpinWaitInst), and using Arm intrinsics. | |||
There was a problem hiding this comment.
The formatting here (line length) is unlike the surrounding text. Not that it matters for the rendered result, of course.
There was a problem hiding this comment.
If you have them, links for some, or all, of those optimizations would help.
There was a problem hiding this comment.
I fixed the formatting and spelling, but I didn't add any links.
There was a problem hiding this comment.
We should rewrite this section with our up-to-date recommendations (>=Corretto17) and put the disclaimer about Corretto8 towards the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add details about reasons to upgrade from JDK8.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.