chore(middleware-flexible-checksums): add config resolver #6470
+76
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
changed the title
kuhe
reviewed
Sep 13, 2024
| export const resolveFlexibleChecksumsConfig = <T>( | ||
| input: T & FlexibleChecksumsInputConfig | ||
| ): T & FlexibleChecksumsResolvedConfig => ({ | ||
| ...input, |
There was a problem hiding this comment.
Not something to address for this PR, but overall I think we should mutate directly instead of shallow-copy-and-write Object.assign.
This is a config resolver and not in a hot path so it's fine here.
kuhe
approved these changes
Sep 13, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-5396
Description
Add resolver for flexible checksums.
This PR also moves default values for configurations to constants.
Testing
CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.