Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsii watch: emit code even if typescript compilation failed #235

Closed
eladb opened this issue Sep 17, 2018 · 0 comments
Closed

jsii watch: emit code even if typescript compilation failed #235

eladb opened this issue Sep 17, 2018 · 0 comments
Assignees
@RomainMuller

Comments

@eladb
Copy link
Contributor

eladb commented Sep 17, 2018

When in "watch" mode, it would be useful to emit .js code even if typescript/jsii compilation failed. It is useful for faster iteration.
RomainMuller added a commit that referenced this issue Sep 18, 2018
@RomainMuller
fix(jsii): Don't skip emit on TS errors when in "watch" mode
30b475d 
In watch mode, users expect to be able to be a little more drafty than when doing a plain compile cycle, as
they may edit code as part of a troubleshooting loop, that may involve for example leaving out unused
imports and the like. This change makes sure the `noEmitOnError` compiler option is set to false when
operating in `watch` mode, so the `.js` files get updated unconditionally.

Fixes #235
@RomainMuller RomainMuller mentioned this issue Sep 18, 2018
Merged
RomainMuller added a commit that referenced this issue Sep 19, 2018
@RomainMuller
fix(jsii): Don't skip emit on TS errors when in "watch" mode (#236)
30d1491 
In watch mode, users expect to be able to be a little more drafty than when doing a plain compile cycle, as
they may edit code as part of a troubleshooting loop, that may involve for example leaving out unused
imports and the like. This change makes sure the `noEmitOnError` compiler option is set to false when
operating in `watch` mode, so the `.js` files get updated unconditionally.

Fixes #235
eladb pushed a commit that referenced this issue Sep 20, 2018
v0.7.6 (#239)
04cb6bb 
Bug Fixes
======================
 * Sphinx generated incorrect type references for display ([#232](#232)) ([b664805](b664805))
* **jsii:** Defaulted parameters were not rendered as optional ([#234](#234)) ([578bf9c](578bf9c)), closes [#233](#233)
* **jsii:** Don't skip emit on TS errors when in "watch" mode ([#236](#236)) ([30d1491](30d1491)), closes [#235](#235)
* **jsii:** Optional `any` represented as required ([#237](#237)) ([91074f3](91074f3)), closes [#230](#230)

Features
======================
 * **sphinx:** allow readme file to define sphinx header and reorganize topic ([#229](#229)) ([405da9c](405da9c)), closes [#228](#228) [#185](#185)
* Document overriden/inherited members ([#238](#238)) ([7a6278a](7a6278a)), closes [#196](#196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RomainMuller @eladb