add annotation to package docs when the service shape is deprecated #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wty-Bryant
approved these changes
Oct 7, 2024
Madrigal
approved these changes
Oct 7, 2024
| @@ -756,6 +756,13 @@ public boolean writePackageShapeDocs(Shape shape) { | |||
| .map(DocumentationTrait::getValue) | |||
| .map(docs -> { | |||
| writePackageDocs(docs); | |||
| if (shape.hasTrait(DeprecatedTrait.class)) { | |||
There was a problem hiding this comment.
rant: I see what they were trying to do with the shape API returning optional, but this whole setup is just awkward to do on map-streams. I'd rather have this as just imperative code at this point, but not blocking the review on this since the rest of the methods are written on this style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.