Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bookmark override link from Java SDK metadata #86

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Laren-AWS
Copy link
Contributor

Now that Java examples are mostly using the standard README format, this custom bookmark is no longer needed. This custom bookmark was also breaking tributary's ability to include their own bookmark links.

  • For examples in WRITEME format, the bookmark link works as expected by scrolling down to the Code examples section.
  • For examples in non-standard README format, the bookmark is ignored and link goes to the top of the file. This is acceptable.
  • For tributaries that use their own GitHub URLs, they can add a bookmark and have it work as expected.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Laren-AWS Laren-AWS self-assigned this Sep 12, 2024
@Laren-AWS Laren-AWS added the Bug An update to fix incorrect code or typos. label Sep 12, 2024
@cpyle0819 cpyle0819 merged commit c1ac4b7 into main Sep 13, 2024
2 of 3 checks passed
@cpyle0819 cpyle0819 deleted the remove-java-bookmark branch September 13, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An update to fix incorrect code or typos.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants