chore: support ARM architecture #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the images pushed were only for amd64 architecture. This adds support for building arm64 images. Their respective images will now have a suffix indicating their architecture, e.g. `amazon/amazon-ecs-local-container-endpoints:latest-arm64` This change also ensures that go1.15 is being used to build.
efekarakus
reviewed
Mar 12, 2021
To ensure that the docker images being built are using the binary compiled for the correct architecture, we are using the `--build-args` flag to pass in the architecture as a parameter to the Dockerfile.
SoManyHs
force-pushed
the
arm-support
branch
4 times, most recently
from
811fff5
to
a05597e
Compare
Use CDK to create a pipeline stack that uses a GitHub webhook and CodeBuild to publish docker images for amd64 and arm64 architectures to DockerHub. TODO: Also publish to ECR Public
|
Tested new infrastructure by deploying pipeline to personal test account:
Images for both architectures were pushed to personal test DockerHub account, with images built for correct architecture:
|
|
With successful verification stage added: Note: -- the
|
efekarakus
reviewed
Mar 26, 2021
efekarakus
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the images pushed were only for amd64 architecture. This
adds support for building arm64 images. Their respective images will now
have a suffix indicating their architecture, e.g.
amazon/amazon-ecs-local-container-endpoints:latest-arm64This change also ensures that go1.15 is being used to build.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.