Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AWS CodeBuild to compile C++ binary #469

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Use AWS CodeBuild to compile C++ binary #469

merged 1 commit into from
Jan 11, 2023

Conversation

zengyu714
Copy link
Contributor

Issue #, if available:

Description of changes:

  • This PR introduces CodeBuild to fetch the image that we previously used to build KPL; this will help to reduce regression caused by inconsistent underlying hardware for compilation
  • Travis configuration file was deleted since it was no longer needed

Testing

  • Tested with CodeBuild that can compile binaries successfully

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

shanmsac
shanmsac reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@shanmsac shanmsac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zengyu714
Copy link
Contributor Author

do we need the .travis.yml file?

No, we used to use it for Travis builds, but Travis has been suspended in our org, so we no longer need it.

@zengyu714 zengyu714 merged commit 76d7c1b into awslabs:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanmsac shanmsac shanmsac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zengyu714 @shanmsac