add managed prometheus + workspace endpoints support #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazzy89
reviewed
Aug 25, 2022
handler/aws.go
Outdated
| @@ -47,6 +47,14 @@ func init() { | |||
| host := fmt.Sprintf("%s.es.amazonaws.com", region) | |||
| services[host] = endpoints.ResolvedEndpoint{URL: fmt.Sprintf("https://%s", host), SigningMethod: "v4", SigningRegion: region, SigningName: "es", PartitionID: "aws"} | |||
| } | |||
| // Add managed prometheus + workspace endpoints | |||
| for region := range endpoints.AwsPartition().Regions() { | |||
| host_aps := fmt.Sprintf("aps.%s.amazonaws.com", region) | |||
There was a problem hiding this comment.
better to use here camelCase notation as a guideline in go
|
Btw I've tested this locally and it works for me. |
alvinlin123
approved these changes
Aug 26, 2022
update camel case as recommended by mazzy89.
|
update with camel case as @mazzy89 suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the issue when prometheus workspace access, it will show the error of
unable to proxy request - unable to determine service from host: aps-workspaces.REGION.amazonaws.comDescription of changes:
add explicit mapping for aps-workspaces to aps with sigv4 support.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.