Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when converting infinite values to JSON string #66

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. fix the issue with converting non-finite values to JSON string

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the bug Something isn't working label May 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.90%. Comparing base (d302585) to head (f218f92).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   96.82%   96.90%   +0.08%     
==========================================
  Files          35       35              
  Lines        1667     1681      +14     
==========================================
+ Hits         1614     1629      +15     
+ Misses         53       52       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhu-xiaowei zhu-xiaowei requested a review from zxkane May 30, 2024 02:56
@zhu-xiaowei zhu-xiaowei self-assigned this May 30, 2024
@zxkane zxkane changed the title fix: the issue with converting non-finite values to JSON string fix: the issue with converting infinite values to JSON string Jun 2, 2024
@zxkane zxkane changed the title fix: the issue with converting infinite values to JSON string fix: crash when converting infinite values to JSON string Jun 2, 2024
@zxkane zxkane merged commit 1e91c07 into main Jun 3, 2024
6 checks passed
@zxkane zxkane deleted the fix-json-convert branch June 3, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants