Prevent empty Map component from blocking submissions page #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking a quick look |
jacobtylerwalls
changed the title
rajadain
approved these changes
Oct 5, 2022
jacobtylerwalls
force-pushed
the
jw/empty-map-component
branch
from
8c28b10
to
de149b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates to #99 described in #99 (comment) prevented the submissions page from loading. Now, this PR restores the original behavior on that branch of moving the
<Map>component into theWelcomeandDrawpages.Notes
Investigation showed that we were re-fetching the map anyway when navigating between welcome and draw. I opened #102 to address this.
Testing Instructions
Checklist
fixup!commits have been squashedCHANGELOG.mdupdated with summary of features or fixes, following Keep a Changelog guidelinesREADME.mdupdated if necessary to reflect the changes