Return User Info from Login Endpoint #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajadain
force-pushed
the
tt/get-user-info-from-login
branch
from
e55f202
to
253bfc8
Compare
|
Taking a look now. |
rajadain
force-pushed
the
tt/get-user-info-from-login
branch
from
253bfc8
to
1f7fb35
Compare
|
For some reason the linter integration with my VSCode isn't working, leading to all the linting errors. 9552480 should be the last fix that takes care of it. |
|
One thing quickly, since I know you're online. With this PR we now lose the ability to keep the user logged in after refresh, i.e. when we lose redux state. I don't know if our usual approach is to persist the redux state, or to tolerate more API calls, or to just tolerate logging the user out. |
|
Nice catch! Had missed saving the user state in PrivateRoute. Fixed in 33930fe |
jacobtylerwalls
approved these changes
Oct 13, 2022
The State serializer is very minimal, fits its current purpose. Other more detailed serializers may be added in the future.
When fetching an already logged in user, or logging in a new user, always return the user's email, role, and utilities. This will be used to inform the front-end about various decisions.
Now that the API returns a user object with details, we store the whole thing in Redux, and switch away from signedIn: true as the signifier for login state.
Now that the login endpoint gives us the user's utilities, we use those instead of the placeholders in the UI. Also update the redux logic to match the back-end utility data structure.
rajadain
force-pushed
the
tt/get-user-info-from-login
branch
from
33930fe
to
638859e
Compare
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Returns user details from the login endpoint. Both when logging in a new user, and when fetching an already logged in user, we return details about the user, which include their email, Role, and list of Utilities.
Adds a Utility and State serializer along the way. Updates front-end redux arrangement to consume the new user object for login state management. Also uses the user's list of utilities to correctly render the Nav Bar.
Closes #123
Demo
Testing Instructions
serverChecklist
fixup!commits have been squashedCHANGELOG.mdupdated with summary of features or fixes, following Keep a Changelog guidelinesREADME.mdupdated if necessary to reflect the changes