-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save shape updates #141
Merged
Merged
Save shape updates #141
Commits on Oct 20, 2022
-
There are two reasons to do this: The first is that it's less ambiguous than using `const { id } = useParams()`. This is especially important in deeply nested components where there are other elements with their own IDs. Second, if this logic were to change at a later point (perhaps it is moved into a Context), then it can be updated in one place.
Matt Stone committedOct 20, 2022 Configuration menu - View commit details
-
Copy full SHA for 5a403cb - Browse repository at this point
Copy the full SHA 5a403cbView commit details -
Update draw page to save polygon
This does not include the back-end changes which will follow in a later commit.
Matt Stone committedOct 20, 2022 Configuration menu - View commit details
-
Copy full SHA for e0bf015 - Browse repository at this point
Copy the full SHA e0bf015View commit details -
Add update boundary shape route
Matt Stone committedOct 20, 2022 Configuration menu - View commit details
-
Copy full SHA for b5ad762 - Browse repository at this point
Copy the full SHA b5ad762View commit details -
Matt Stone committed
Oct 20, 2022 Configuration menu - View commit details
-
Copy full SHA for 8d3772f - Browse repository at this point
Copy the full SHA 8d3772fView commit details -
Add useEndpointToastError hook
This could be useful in many components.
Matt Stone committedOct 20, 2022 Configuration menu - View commit details
-
Copy full SHA for c824157 - Browse repository at this point
Copy the full SHA c824157View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b9520a - Browse repository at this point
Copy the full SHA 2b9520aView commit details -
Move boundary details query inside <Map>
When the query was outside of the <Map> component, it would cause re-render of the map each time the query data was updated.
Matt Stone committedOct 20, 2022 Configuration menu - View commit details
-
Copy full SHA for 551e61d - Browse repository at this point
Copy the full SHA 551e61dView commit details -
Don't revert shape edits on save failure
These changes are intentionally not fixed up into ff73200 because it can serve as a reference for how to revere manaual cache updates.
Matt Stone committedOct 20, 2022 Configuration menu - View commit details
-
Copy full SHA for 5c56803 - Browse repository at this point
Copy the full SHA 5c56803View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.