Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 18 #19

Merged
merged 4 commits into from
Aug 8, 2022
Merged

Upgrade to Node 18 #19

merged 4 commits into from
Aug 8, 2022

Conversation

mstone121
Copy link
Contributor

@mstone121 mstone121 commented Aug 8, 2022

Overview

Node 16 will soon be out-of-date as Node 18 is set to become the LTS version in October 2022.

Connects #17

Notes

The only issue with upgrading has been a cryptic error that seems to be related to openssl:

Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)

Forcing node to use a legacy ssl provider is a temporary workaround. More info can be found in the node release notes.

I think the root cause is a module that's using unsupported openssl functions. If there is a way to get webpack to output more logging info while it's bundling, it could help track down which module it might be coming from.

@mstone121 mstone121 requested a review from rajadain August 8, 2022 18:59
@rajadain rajadain self-assigned this Aug 8, 2022
@rajadain rajadain added the Task 3.2 Front-end prototype label Aug 8, 2022
Copy link
Contributor

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested! This is working well. While the legacy SSL option doesn't sound the most secure, it is no worse off than Node 16, and should be fine for the development environment in which we use it.

Nice clean diff!

@rajadain rajadain assigned mstone121 and unassigned rajadain Aug 8, 2022
@rajadain
Copy link
Contributor

rajadain commented Aug 8, 2022

Reminder to add a CHANGELOG entry before merging!

@mstone121 mstone121 merged commit bac037b into develop Aug 8, 2022
@mstone121 mstone121 deleted the ms/upgrade-node branch August 8, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task 3.2 Front-end prototype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants