Fix contributor welcome redirect #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstone121
force-pushed
the
ms/fix-contributor-welcome-redirect
branch
from
ca3af77
to
6359528
Compare
rajadain
approved these changes
Nov 11, 2022
added 3 commits
November 11, 2022 09:55
This keeps the NavBar from flashing when redirecting to Welcome for contributors.
mstone121
force-pushed
the
ms/fix-contributor-welcome-redirect
branch
from
6359528
to
2693db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the login redirect for contributors so they are taken to the welcome page if they select a utility that has no submissions.
It also updates the navbar to render on only on explicitly listed pages. This keeps it from flashing when the contributor is redirected to /welcome.
Closes #190
Notes
Having
/drawin/submissionslike/submissions/4/drawwould simplify how the navbar is included and would help with solving #184.Testing Instructions
Checklist
fixup!commits have been squashedCHANGELOG.mdupdated with summary of features or fixes, following Keep a Changelog guidelinesREADME.mdupdated if necessary to reflect the changes