-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labels to municipal boundaries layer #61
Conversation
Taking a quick look |
I like the implementation, it's neat and clean. One idea I had was to use the darkest and lightest purple for the labels, instead of black and white, to make the labels visually associate more with the layer. But also, I wanted to record what the labels look like: 2022-09-12.17.56.35.mp4and ask the UX folks, is this okay? Are there any styling changes you would recommend? /cc @gatesgodin @caseycesari |
The labels look great to me. The labels might need a thicker white stroke when on the satellite view for legibility. @rajadain |
Let's go with this: .muni-label {
background: rgba(255, 255, 255, 0);
border: 0;
border-radius: 0px;
box-shadow: 0 0px 0px;
font-weight: bold;
font-size: var(--chakra-fontSizes-sm);
color: var(--chakra-colors-purple-900);
text-shadow: 0 0 0.2em var(--chakra-colors-purple-50), 0 0 0.2em var(--chakra-colors-purple-50);
}
.muni-label-light {
color: var(--chakra-colors-purple-50);
text-shadow: 0 0 0.2em var(--chakra-colors-purple-900), 0 0 0.2em var(--chakra-colors-purple-900);
} The |
That looks good to me too! |
3b9b071
to
6729ef7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Overview
This PR adds labels to the municipal boundaries layer.
If the zoom level is less than 9, the labels are not shown as this gets too busy.
On the satellite basemap, the labels are white text instead of the default black.
Closes #49
Demo
Testing Instructions
Checklist
fixup!
commits have been squashedCHANGELOG.md
updated with summary of features or fixes, following Keep a Changelog guidelinesREADME.md
updated if necessary to reflect the changes