Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must be added to SmartScripts #1607

Closed
IntelligentQuantum opened this issue Jan 5, 2022 · 8 comments
Closed

Must be added to SmartScripts #1607

IntelligentQuantum opened this issue Jan 5, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@IntelligentQuantum
Copy link
Member

IntelligentQuantum commented Jan 5, 2022

Do not close this issue, i will add more smartscript in the future.

List

@FrancescoBorzi FrancescoBorzi added the enhancement New feature or request label Feb 13, 2022
@Gultask
Copy link
Contributor

Gultask commented Jan 31, 2023

@avarishd
Copy link
Contributor

avarishd commented Mar 21, 2023

I think these are all of the missing things in keira. (from the lists above, except SMART_ACTION_SET_CAN_FLY NYI/Unused)
"//" = Missing entirely, without = missing only param(s)

-- Targets
SMART_TARGET_LOOT_RECIPIENTS 27 // All players that have tagged this creature (for kill credit)

SMART_TARGET_VEHICLE_PASSENGER 29 // Targets seat number if the target is a vehicle
param1 = seat number (vehicle can target it's own accessory)

-- Events
SMART_EVENT_ACCEPTED_QUEST 19
param2 = CooldownMin, param3 = CooldownMax

SMART_EVENT_REWARD_QUEST 20
param2 = CooldownMin, param3 = CooldownMax

SMART_EVENT_CHARMED 29
param1 = onRemove (0 - on apply, 1 - on remove)

SMART_EVENT_EVENT_PHASE_CHANGE 66 // On event phase mask set
param1 = event phase mask

SMART_EVENT_SUMMONED_UNIT_DIES 82 // When specified creature (or 0, for all) dies
param1 = CreatureId(0 all), param2 = CooldownMin, param3 = CooldownMax


-- Actions
SMART_ACTION_SOUND 4 ---- current param(s) are wrong.
param1 = SoundId, param2 = onlySelf (0/1), param3 = distance

SMART_ACTION_SUMMON_GO 50
param4 = summonType (0 - after a specified time OR when the summoner dies, 1 - after a specified time)

SMART_ACTION_RANDOM_SOUND 115
param1-4 = soundid1-4, param5 = onlySelf (0/1), param6 = distance

SMART_ACTION_SET_CORPSE_DELAY 116 // Allows setting the delay of corpse decay time
param1 = timer

SMART_ACTION_DISABLE_EVADE 117 // Allow evading or not
param1 = 0/1 (1 = disabled, 0 = enabled)

SMART_ACTION_GO_SET_GO_STATE 118 // Control the specified Gameobject GO State
param1 = state

SMART_ACTION_PLAY_CINEMATIC 135 // Play a cinematic
param1 = entry, param2 = cinematic

SMART_ACTION_SET_MOVEMENT_SPEED 136 // Modifies the current speed and movementType
param1 = movementType, param2 = speedInteger, param3 = speedFraction

movementType 
    MOVE_WALK           = 0,
    MOVE_RUN            = 1,
    MOVE_RUN_BACK       = 2,
    MOVE_SWIM           = 3,
    MOVE_SWIM_BACK      = 4,
    MOVE_TURN_RATE      = 5,
    MOVE_FLIGHT         = 6,
    MOVE_FLIGHT_BACK    = 7,
    MOVE_PITCH_RATE     = 8

SMART_ACTION_SET_HEALTH_PCT 142 // Change the specified target health percent
param1 = percent

SMART_ACTION_DO_ACTION 223 // Allows to call for a DoAction in code
param1 = ActionId

SMART_ACTION_ATTACK_STOP 224 // Stop melee, spell casting during combat, chasing the target and facing

@avarishd
Copy link
Contributor

Stuff above have been added, only missing comment generation for them now.

@Gultask
Copy link
Contributor

Gultask commented May 17, 2023

@Nefertumm
Copy link
Member

@Helias
Copy link
Member

Helias commented Jul 30, 2023

is everything has been added? anything missing?

@Gultask
Copy link
Contributor

Gultask commented Jul 31, 2023

I completely forgot to add SMART_TARGETS in the last PR
Also comments need reorganizing. I'll see what I can do this week

@Helias
Copy link
Member

Helias commented Aug 3, 2023

the last ones have been added by #2347, thanks @Gultask

@Helias Helias closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants