More SAI #2347
Merged
More SAI #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helias
reviewed
Jul 31, 2023
src/app/shared/modules/sai-editor/sai-comment-generator.service.ts
Outdated
Show resolved
Hide resolved
Helias
reviewed
Jul 31, 2023
src/app/shared/modules/sai-editor/sai-comment-generator.service.ts
Outdated
Show resolved
Hide resolved
Helias
reviewed
Jul 31, 2023
src/app/shared/modules/sai-editor/sai-comment-generator.service.ts
Outdated
Show resolved
Hide resolved
|
ignore the macos CI, it's a bit bugged |
…e.ts Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
…e.ts Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
…e.ts Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
|
I don't really know how to compile it yet, sorry :( I'll see about compiling it to test, otherwise the only testing needed is for the new comment generator lines added |
|
Should be done now |
|
I will check why the pipeline is failing and fix the unit-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge yet, need to test