Core/Fixes: Update Informations #23

Bodeguero · 2016-07-23T12:50:39Z

Update Welcome Message

* Update Welcome Message

FrancescoBorzi · 2016-07-23T16:30:39Z

src/server/authserver/Main.cpp

@@ -113,7 +113,25 @@ extern int main(int argc, char** argv)

    sLog->outString("%s (authserver)", _FULLVERSION);
    sLog->outString("<Ctrl-C> to stop.\n");
-    sLog->outString("Using configuration file %s.", configFile);


why did you remove this line?

@ShinDarth I did not remove the line it is in the code:
Look carefully

you're right, the problem is that you changed the code indentation... can you fix it (in all new lines)?

@ShinDarth Fix what? What mistakes this time? The code was infuncional? You have errors in time to make the compilation? What is the problem this time in the code?

ghost · 2016-07-24T14:48:15Z

Quite simply, in the studio there are indentation settings. Error is not here, just standard C++.

FrancescoBorzi · 2016-07-24T15:04:43Z

This PR can be closed, see #32

## Type(Scope/Subscope): Commit ultra short explanation ## |---- Write below the examples with a maximum of 50 characters ----| ## Example 1: fix(DB/SAI): Missing spell to NPC Hogger ## Example 2: fix(CORE/Raid): Phase 2 of Ragnaros ## Example 3: feat(CORE/Commands): New GM command to do something fix(Core/Events): Hallows end hardcoded strings. ### DESCRIPTION ## Explain why this change is being made, what does it fix etc... ## |---- Write below the examples with a maximum of 72 characters per lines ----| ## Example: Hogger (id: 492) was not charging player when being engaged. ## Provide links to any issue, commit, pull request or other resource ## Example 1: Closes AzerothCore issue azerothcore#23 ## Example 2: Ported from other project's commit (link) ## Example 3: References taken from wowpedia / wowhead / wowwiki / https://wowgaming.altervista.org/aowow/ The event of Hallows end (hallows_end.cpp) had hardcoded strings, were replaced according tobroadcast_text. ### CO-AUTHOR(S) ## If there are more authors they can be mentioned like this ## Co-authored-by: name <name@example.com> ## ======================================================= ## EXTRA INFOS ## ======================================================= ## "Type" can be: ## feat (new feature) ## fix (bug fix) ## refactor (refactoring production code) ## style (formatting, missing semi colons, etc; no code change) ## docs (changes to documentation) ## test (adding or refactoring tests; no production code change) ## chore (updating bash scripts, git files etc; no production code change) ## -------------------- ## Remember to ## Capitalize the subject line ## Use the imperative mood in the subject line ## Do not end the subject line with a period ## Separate subject from body with a blank line ## Use the body to explain what and why rather than how ## Can use multiple lines with "-" for bullet points in body ## -------------------- ## More info here https://www.conventionalcommits.org/en/v1.0.0-beta.2/ ## ======================================================= ## "Scope" can be: ## CORE (core related, c++) ## DB (database related, sql) ## ======================================================= ## "Subscope" is optional and depends on the nature of the commit. ## =======================================================

## Type(Scope/Subscope): Commit ultra short explanation ## |---- Write below the examples with a maximum of 50 characters ----| ## Example 1: fix(DB/SAI): Missing spell to NPC Hogger ## Example 2: fix(CORE/Raid): Phase 2 of Ragnaros ## Example 3: feat(CORE/Commands): New GM command to do something ### DESCRIPTION ## Explain why this change is being made, what does it fix etc... ## |---- Write below the examples with a maximum of 72 characters per lines ----| ## Example: Hogger (id: 492) was not charging player when being engaged. ## Provide links to any issue, commit, pull request or other resource ## Example 1: Closes AzerothCore issue azerothcore#23 ## Example 2: Ported from other project's commit (link) ## Example 3: References taken from wowpedia / wowhead / wowwiki / https://wowgaming.altervista.org/aowow/ ### CO-AUTHOR(S) ## If there are more authors they can be mentioned like this ## Co-authored-by: name <name@example.com> ## ======================================================= ## EXTRA INFOS ## ======================================================= ## "Type" can be: ## feat (new feature) ## fix (bug fix) ## refactor (refactoring production code) ## style (formatting, missing semi colons, etc; no code change) ## docs (changes to documentation) ## test (adding or refactoring tests; no production code change) ## chore (updating bash scripts, git files etc; no production code change) ## -------------------- ## Remember to ## Capitalize the subject line ## Use the imperative mood in the subject line ## Do not end the subject line with a period ## Separate subject from body with a blank line ## Use the body to explain what and why rather than how ## Can use multiple lines with "-" for bullet points in body ## -------------------- ## More info here https://www.conventionalcommits.org/en/v1.0.0-beta.2/ ## ======================================================= ## "Scope" can be: ## CORE (core related, c++) ## DB (database related, sql) ## ======================================================= ## "Subscope" is optional and depends on the nature of the commit. ## =======================================================

## Type(Scope/Subscope): Commit ultra short explanation ## |---- Write below the examples with a maximum of 50 characters ----| ## Example 1: fix(DB/SAI): Missing spell to NPC Hogger ## Example 2: fix(CORE/Raid): Phase 2 of Ragnaros ## Example 3: feat(CORE/Commands): New GM command to do something fix(CORE/Script): Quest "A Pawn on the Eternal Board" can't finish and hung up the worldserver.exe ### DESCRIPTION ## Explain why this change is being made, what does it fix etc... ## |---- Write below the examples with a maximum of 72 characters per lines ----| ## Example: Hogger (id: 492) was not charging player when being engaged. Quest "A Pawn on the Eternal Board" will hung up the worldserver.exe ## Provide links to any issue, commit, pull request or other resource ## Example 1: Closes AzerothCore issue azerothcore#23 ## Example 2: Ported from other project's commit (link) ## Example 3: References taken from wowpedia / wowhead / wowwiki / https://wowgaming.altervista.org/aowow/ Closes AzerothCore issue azerothcore#11608 ### CO-AUTHOR(S) ## If there are more authors they can be mentioned like this ## Co-authored-by: name <name@example.com> ## ======================================================= ## EXTRA INFOS ## ======================================================= ## "Type" can be: ## feat (new feature) ## fix (bug fix) ## refactor (refactoring production code) ## style (formatting, missing semi colons, etc; no code change) ## docs (changes to documentation) ## test (adding or refactoring tests; no production code change) ## chore (updating bash scripts, git files etc; no production code change) ## -------------------- ## Remember to ## Capitalize the subject line ## Use the imperative mood in the subject line ## Do not end the subject line with a period ## Separate subject from body with a blank line ## Use the body to explain what and why rather than how ## Can use multiple lines with "-" for bullet points in body ## -------------------- ## More info here https://www.conventionalcommits.org/en/v1.0.0-beta.2/ ## ======================================================= ## "Scope" can be: ## CORE (core related, c++) ## DB (database related, sql) ## ======================================================= ## "Subscope" is optional and depends on the nature of the commit. ## =======================================================

## Type(Scope/Subscope): Commit ultra short explanation ## |---- Write below the examples with a maximum of 50 characters ----| ## Example 1: fix(DB/SAI): Missing spell to NPC Hogger ## Example 2: fix(CORE/Raid): Phase 2 of Ragnaros ## Example 3: feat(CORE/Commands): New GM command to do something ### DESCRIPTION ## Explain why this change is being made, what does it fix etc... ## |---- Write below the examples with a maximum of 72 characters per lines ----| ## Example: Hogger (id: 492) was not charging player when being engaged. ## Provide links to any issue, commit, pull request or other resource ## Example 1: Closes issue azerothcore#23 ## Example 2: Ported from other project's commit (link) ## Example 3: References taken from wowpedia / wowhead / wowwiki / https://wowgaming.altervista.org/aowow/ ## ======================================================= ## EXTRA INFOS ## ======================================================= ## "Type" can be: ## feat (new feature) ## fix (bug fix) ## refactor (refactoring production code) ## style (formatting, missing semi colons, etc; no code change) ## docs (changes to documentation) ## test (adding or refactoring tests; no production code change) ## chore (updating bash scripts, git files etc; no production code change) ## -------------------- ## Remember to ## Capitalize the subject line ## Use the imperative mood in the subject line ## Do not end the subject line with a period ## Separate subject from body with a blank line ## Use the body to explain what and why rather than how ## Can use multiple lines with "-" for bullet points in body ## -------------------- ## More info here https://www.conventionalcommits.org/en/v1.0.0-beta.2/ ## ======================================================= ## "Scope" can be: ## CORE (core related, c++) ## DB (database related, sql) ## ======================================================= ## "Subscope" is optional and depends on the nature of the commit. ## =======================================================

## Type(Scope/Subscope): Commit ultra short explanation ## |---- Write below the examples with a maximum of 50 characters ----| ## Example 1: fix(DB/SAI): Missing spell to NPC Hogger ## Example 2: fix(CORE/Raid): Phase 2 of Ragnaros ## Example 3: feat(CORE/Commands): New GM command to do something (Core/Commands): Introduce .npc guid ### DESCRIPTION ## Explain why this change is being made, what does it fix etc... ## |---- Write below the examples with a maximum of 72 characters per lines ----| ## Example: Hogger (id: 492) was not charging player when being engaged. .npc info is too robust and floods the screen .npc guid will simply provide the only first part of .npc info's output ## Provide links to any issue, commit, pull request or other resource ## Example 1: Closes AzerothCore issue azerothcore#23 ## Example 2: Ported from other project's commit (link) ## Example 3: References taken from wowpedia / wowhead / wowwiki / https://wowgaming.altervista.org/aowow/ ### CO-AUTHOR(S) ## If there are more authors they can be mentioned like this ## Co-authored-by: name <name@example.com> ## ======================================================= ## EXTRA INFOS ## ======================================================= ## "Type" can be: ## feat (new feature) ## fix (bug fix) ## refactor (refactoring production code) ## style (formatting, missing semi colons, etc; no code change) ## docs (changes to documentation) ## test (adding or refactoring tests; no production code change) ## chore (updating bash scripts, git files etc; no production code change) ## -------------------- ## Remember to ## Capitalize the subject line ## Use the imperative mood in the subject line ## Do not end the subject line with a period ## Separate subject from body with a blank line ## Use the body to explain what and why rather than how ## Can use multiple lines with "-" for bullet points in body ## -------------------- ## More info here https://www.conventionalcommits.org/en/v1.0.0-beta.2/ ## ======================================================= ## "Scope" can be: ## CORE (core related, c++) ## DB (database related, sql) ## ======================================================= ## "Subscope" is optional and depends on the nature of the commit. ## =======================================================

### TITLE ## Type(Scope/Subscope): Commit ultra short explanation ## |---- Write below the examples with a maximum of 50 characters ----| ## Example 1: fix(DB/SAI): Missing spell to NPC Hogger ## Example 2: fix(CORE/Raid): Phase 2 of Ragnaros ## Example 3: feat(CORE/Commands): New GM command to do something ### DESCRIPTION ## Explain why this change is being made, what does it fix etc... ## |---- Write below the examples with a maximum of 72 characters per lines ----| ## Example: Hogger (id: 492) was not charging player when being engaged. ## Provide links to any issue, commit, pull request or other resource ## Example 1: Closes AzerothCore issue azerothcore#23 ## Example 2: Ported from other project's commit (link) ## Example 3: References taken from wowpedia / wowhead / wowwiki / https://wowgaming.altervista.org/aowow/ ### CO-AUTHOR(S) ## If there are more authors they can be mentioned like this ## Co-authored-by: name <name@example.com> ## ======================================================= ## EXTRA INFOS ## ======================================================= ## "Type" can be: ## feat (new feature) ## fix (bug fix) ## refactor (refactoring production code) ## style (formatting, missing semi colons, etc; no code change) ## docs (changes to documentation) ## test (adding or refactoring tests; no production code change) ## chore (updating bash scripts, git files etc; no production code change) ## -------------------- ## Remember to ## Capitalize the subject line ## Use the imperative mood in the subject line ## Do not end the subject line with a period ## Separate subject from body with a blank line ## Use the body to explain what and why rather than how ## Can use multiple lines with "-" for bullet points in body ## -------------------- ## More info here https://www.conventionalcommits.org/en/v1.0.0-beta.2/ ## ======================================================= ## "Scope" can be: ## CORE (core related, c++) ## DB (database related, sql) ## ======================================================= ## "Subscope" is optional and depends on the nature of the commit. ## =======================================================

FIXME: clean this up / properly implement this functionality ### TITLE ## Type(Scope/Subscope): Commit ultra short explanation ## |---- Write below the examples with a maximum of 50 characters ----| ## Example 1: fix(DB/SAI): Missing spell to NPC Hogger ## Example 2: fix(CORE/Raid): Phase 2 of Ragnaros ## Example 3: feat(CORE/Commands): New GM command to do something ### DESCRIPTION ## Explain why this change is being made, what does it fix etc... ## |---- Write below the examples with a maximum of 72 characters per lines ----| ## Example: Hogger (id: 492) was not charging player when being engaged. ## Provide links to any issue, commit, pull request or other resource ## Example 1: Closes AzerothCore issue azerothcore#23 ## Example 2: Ported from other project's commit (link) ## Example 3: References taken from wowpedia / wowhead / wowwiki / https://wowgaming.altervista.org/aowow/ ### CO-AUTHOR(S) ## If there are more authors they can be mentioned like this ## Co-authored-by: name <name@example.com> ## ======================================================= ## EXTRA INFOS ## ======================================================= ## "Type" can be: ## feat (new feature) ## fix (bug fix) ## refactor (refactoring production code) ## style (formatting, missing semi colons, etc; no code change) ## docs (changes to documentation) ## test (adding or refactoring tests; no production code change) ## chore (updating bash scripts, git files etc; no production code change) ## -------------------- ## Remember to ## Capitalize the subject line ## Use the imperative mood in the subject line ## Do not end the subject line with a period ## Separate subject from body with a blank line ## Use the body to explain what and why rather than how ## Can use multiple lines with "-" for bullet points in body ## -------------------- ## More info here https://www.conventionalcommits.org/en/v1.0.0-beta.2/ ## ======================================================= ## "Scope" can be: ## CORE (core related, c++) ## DB (database related, sql) ## ======================================================= ## "Subscope" is optional and depends on the nature of the commit. ## =======================================================

## Type(Scope/Subscope): Commit ultra short explanation ## |---- Write below the examples with a maximum of 50 characters ----| ## Example 1: fix(DB/SAI): Missing spell to NPC Hogger ## Example 2: fix(CORE/Raid): Phase 2 of Ragnaros ## Example 3: feat(CORE/Commands): New GM command to do something ### DESCRIPTION ## Explain why this change is being made, what does it fix etc... ## |---- Write below the examples with a maximum of 72 characters per lines ----| ## Example: Hogger (id: 492) was not charging player when being engaged. ## Provide links to any issue, commit, pull request or other resource ## Example 1: Closes AzerothCore issue azerothcore#23 ## Example 2: Ported from other project's commit (link) ## Example 3: References taken from wowpedia / wowhead / wowwiki / https://wowgaming.altervista.org/aowow/ ### CO-AUTHOR(S) ## If there are more authors they can be mentioned like this ## Co-authored-by: name <name@example.com> ## ======================================================= ## EXTRA INFOS ## ======================================================= ## "Type" can be: ## feat (new feature) ## fix (bug fix) ## refactor (refactoring production code) ## style (formatting, missing semi colons, etc; no code change) ## docs (changes to documentation) ## test (adding or refactoring tests; no production code change) ## chore (updating bash scripts, git files etc; no production code change) ## -------------------- ## Remember to ## Capitalize the subject line ## Use the imperative mood in the subject line ## Do not end the subject line with a period ## Separate subject from body with a blank line ## Use the body to explain what and why rather than how ## Can use multiple lines with "-" for bullet points in body ## -------------------- ## More info here https://www.conventionalcommits.org/en/v1.0.0-beta.2/ ## ======================================================= ## "Scope" can be: ## CORE (core related, c++) ## DB (database related, sql) ## ======================================================= ## "Subscope" is optional and depends on the nature of the commit. ## =======================================================

### DESCRIPTION ## Explain why this change is being made, what does it fix etc... ## |---- Write below the examples with a maximum of 72 characters per lines ----| ## Example: Hogger (id: 492) was not charging player when being engaged. Channel the same spell as the original caster when clicking on a ritual portal, but ignore the effects of the spell. ## Provide links to any issue, commit, pull request or other resource ## Example 1: Closes AzerothCore issue azerothcore#23 ## Example 2: Ported from other project's commit (link) ## Example 3: References taken from wowpedia / wowhead / wowwiki / https://wowgaming.altervista.org/aowow/ ### CO-AUTHOR(S) ## If there are more authors they can be mentioned like this ## Co-authored-by: name <name@example.com> ## ======================================================= ## EXTRA INFOS ## ======================================================= ## "Type" can be: ## feat (new feature) ## fix (bug fix) ## refactor (refactoring production code) ## style (formatting, missing semi colons, etc; no code change) ## docs (changes to documentation) ## test (adding or refactoring tests; no production code change) ## chore (updating bash scripts, git files etc; no production code change) ## -------------------- ## Remember to ## Capitalize the subject line ## Use the imperative mood in the subject line ## Do not end the subject line with a period ## Separate subject from body with a blank line ## Use the body to explain what and why rather than how ## Can use multiple lines with "-" for bullet points in body ## -------------------- ## More info here https://www.conventionalcommits.org/en/v1.0.0-beta.2/ ## ======================================================= ## "Scope" can be: ## CORE (core related, c++) ## DB (database related, sql) ## ======================================================= ## "Subscope" is optional and depends on the nature of the commit. ## =======================================================

Core/Fixes: Update Informations

6122717

* Update Welcome Message

Bodeguero mentioned this pull request Jul 23, 2016

Core/Fixes: Update Source AzerothCore #18

Closed

FrancescoBorzi reviewed Jul 23, 2016
View reviewed changes

Bodeguero closed this Jul 24, 2016

Si1ker mentioned this pull request Mar 4, 2020

fix(DB): Ashenvale Hunt deDE Quest Texts #2730

Merged

1 task

Azcobu mentioned this pull request Nov 4, 2021

Sayge's Fortunes Incorrectly Dropping From NPCs #8943

Closed

8 tasks

neifion-00000000 mentioned this pull request Jul 19, 2022

(Core/Commands): Introduce .npc guid #12440

Merged

kissingers mentioned this pull request Feb 13, 2023

[Crash] Server Crash 0213 #14989

Closed

liyunfan1223 mentioned this pull request Oct 25, 2023

Dead loop during RemoveAllAurasOnDeath for spell 38067(Guard's Mark) #17580

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core/Fixes: Update Informations #23

Core/Fixes: Update Informations #23

Bodeguero commented Jul 23, 2016

FrancescoBorzi Jul 23, 2016

Bodeguero Jul 23, 2016 •

edited

Loading

FrancescoBorzi Jul 23, 2016

Bodeguero Jul 24, 2016

ghost commented Jul 24, 2016

FrancescoBorzi commented Jul 24, 2016

Core/Fixes: Update Informations #23

Core/Fixes: Update Informations #23

Conversation

Bodeguero commented Jul 23, 2016

FrancescoBorzi Jul 23, 2016

Choose a reason for hiding this comment

Bodeguero Jul 23, 2016 • edited Loading

Choose a reason for hiding this comment

FrancescoBorzi Jul 23, 2016

Choose a reason for hiding this comment

Bodeguero Jul 24, 2016

Choose a reason for hiding this comment

ghost commented Jul 24, 2016

FrancescoBorzi commented Jul 24, 2016

Bodeguero Jul 23, 2016 •

edited

Loading