Object/Person/Face views #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… msgs are now used
|
Kudos, SonarCloud Quality Gate passed!
|
|
@alex-mitrevski I turned it into a draft, this should avoid triggering reminders in Slack. I think if when the PR is opened, you mark it as a draft, then reviewers don't get added (so you don't have to do it manually each time), at least according to this:
We could also update the CODEOWNERS file and repo settings for the review process (requesting manually vs adding automatic reviewers). |
This was referenced Aug 14, 2020
alex-mitrevski
changed the title
|
@argenos The draft PR sounds good; I'll try that next time. I think the automatic review assignment can remain, it's good to have in general. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the use of the
Person,Face, andObjectmessages in the repository so that theObjectViewmessage (added with b-it-bots/mas_perception_msgs#11) is used when storing images and/or point clouds.