Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix mkdir #128

Merged
merged 12 commits into from
Feb 3, 2022
Merged

Fix mkdir #128

merged 12 commits into from
Feb 3, 2022

Conversation

Fl4m3Ph03n1x
Copy link
Contributor

This is the follow up of my research on this ticket: #127
After smashing my head against a wall for several days, I think I finally figured it out.
The command was failing because of how cmd mkdir behaves, in that, it behaves different from the one in poewrshell.

By changing that 1 line of code to only create folders if they don't exist already, I was able to fix the issue while still mantaining backwards compatibility, which was one of my requirements.

You can see a MWE project using my forked branch of bakeware here:

Please let me know what you think, and merge when convenient.

@fhunleth
Copy link
Contributor

fhunleth commented Feb 3, 2022

Looks good to me. Thanks!

@Fl4m3Ph03n1x
Copy link
Contributor Author

Fl4m3Ph03n1x commented Feb 4, 2022

Given this PR merges a fix for an issue with the Makefile, could we please do a 0.2.3 release?
This way other users that wish to use this library won't have to go to the same debugging process I had, it will simply work.

@Fl4m3Ph03n1x Fl4m3Ph03n1x deleted the fix-mkdir branch February 4, 2022 09:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants