Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Localizable.localize() return Localized & str #1848

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

bartfeenstra
Copy link
Owner

@bartfeenstra bartfeenstra commented Aug 5, 2024

This allows calling code to know which locale something was localized to. When templating, this means we can add the correct HTML lang attributes.

@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations python Pull requests that update Python code templating Jinja2 templating labels Aug 5, 2024
@bartfeenstra bartfeenstra added this to the 0.4.x milestone Aug 5, 2024
@bartfeenstra bartfeenstra changed the title Make Localizable.localize() return a Localized Make Localizable.localize() return a Localized & str Aug 5, 2024
@bartfeenstra bartfeenstra force-pushed the localizable-localize-produces-localized branch 2 times, most recently from 5c86007 to 6e9232d Compare August 5, 2024 11:12
@bartfeenstra bartfeenstra changed the title Make Localizable.localize() return a Localized & str Make Localizable.localize() return Localized & str Aug 5, 2024
@bartfeenstra bartfeenstra force-pushed the localizable-localize-produces-localized branch from b70e05d to 66fd55b Compare August 5, 2024 12:25
@bartfeenstra bartfeenstra marked this pull request as ready for review August 5, 2024 12:25
@bartfeenstra bartfeenstra merged commit 4542652 into 0.4.x Aug 5, 2024
5 checks passed
@bartfeenstra bartfeenstra deleted the localizable-localize-produces-localized branch August 5, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code templating Jinja2 templating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant