-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Store reverse deps of size 2-4 as a
SkyKey[]
instead of an `ArrayLi…
…st`. Most nodes have a small number of reverse deps. There is already an optimization to store a single reverse dep bare. This change extends the optimization to forego an `ArrayList` wrapper (24 bytes) when there are 2-4 elements. Additionally, this saves space that was being wasted on over-allocating the size of the backing array by calling `Lists.newArrayListWithExpectedSize(2)`, which per the Javadoc on that method, adds "an unspecified amount of padding" (also, the Javadoc discourages using the method altogether). The actual calculation is `5L + arraySize + (arraySize / 10)`, which means for an input of 2 we were allocating an array of size 7. PiperOrigin-RevId: 540717655 Change-Id: I8d485f8ca463a4178e2844491928748d5f6c182c
- Loading branch information
1 parent
fed23d5
commit ae6b3a5
Showing
2 changed files
with
71 additions
and
74 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters