Skip to content

Commit

Permalink
have 'bazel test' non-test targets depend on --remote_download_output
Browse files Browse the repository at this point in the history
This fixes #17190

Closes #17195.

PiperOrigin-RevId: 501555041
Change-Id: Ie52f72fb82912dde135eaa56c02d9756eb31365b
  • Loading branch information
antter authored and copybara-github committed Jan 12, 2023
1 parent 36a93f9 commit e8182ce
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,9 @@ private boolean shouldDownloadToplevelOutputs(ConfiguredTargetKey configuredTarg
if (configuredTarget instanceof RuleConfiguredTarget) {
var ruleConfiguredTarget = (RuleConfiguredTarget) configuredTarget;
var isTestRule = isTestRuleName(ruleConfiguredTarget.getRuleClassString());
return !isTestRule;
return !isTestRule && downloadToplevel;
}
return true;
return downloadToplevel;
} catch (InterruptedException ignored) {
Thread.currentThread().interrupt();
return false;
Expand Down

0 comments on commit e8182ce

Please sign in to comment.