Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0.0/5.2.0] external_include_paths no work for emitting warnings for external sources #15762

Closed
qchenzi opened this issue Jun 29, 2022 · 3 comments
Closed

[5.0.0/5.2.0] external_include_paths no work for emitting warnings for external sources #15762

qchenzi opened this issue Jun 29, 2022 · 3 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-CPP Issues for C++ rules type: bug

Comments

@qchenzi
Copy link

qchenzi commented Jun 29, 2022 •
edited
Loading

external_include_paths no work for emitting warnings for external sources

I added the following to my project's .bazelrc file,
build --features=external_include_paths

I hope that will emit warnings for external deps, but it is not helping me, it is still giving me errors.

企业微信截图_5967e582-a368-483f-b325-28d046587805
@sgowroji
Copy link
Member

Hello @qchenzi, Could you please provide steps to reproduce the request. Thanks!

@qchenzi
Copy link
Author

qchenzi commented Jun 29, 2022

@sgowroji Thanks for your reply, I added com_github_jupp0r_prometheus_cpp as the external deps by using http_archive.
Besides, I added build --features=external_include_paths to my project's .bazelrc file as following:
企业微信截图_d66907af-6b26-45d5-b1d5-67c49829c265

Finally, I executed command bazel build //myproject/..., but I still get this error.

@sgowroji sgowroji added type: bug team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged and removed more data needed labels Jun 29, 2022
@qchenzi qchenzi changed the title bazel5.0.0 external_include_paths no work for emitting warnings for external sources [5.0.0/5.2.0] external_include_paths no work for emitting warnings for external sources Jun 30, 2022
@meteorcloudy meteorcloudy added team-Rules-CPP Issues for C++ rules and removed team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Jul 5, 2022
@oquenchil oquenchil added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Jul 7, 2022
This was referenced Jul 13, 2022
Closed
Closed
@lripoche
Copy link
Contributor

still occurring with bazel 5.3.2, any update on this ?

@lripoche lripoche mentioned this issue Nov 8, 2022
Closed
hvadehra pushed a commit that referenced this issue Feb 14, 2023
@lripoche @hvadehra
add external_include_paths feature on windows cpp toolchain
4a658b8 
Potentially fix #15762 and #15865 (if they depend on windows).

Linked to 08936ae

Closes #16694.

PiperOrigin-RevId: 505084880
Change-Id: Ie4dc08a0e93c76419b6164bacccadac32a7c7b2f
lripoche added a commit to lripoche/bazel that referenced this issue Apr 20, 2023
@lripoche
add external_include_paths feature on windows cpp toolchain
98ae533 
Potentially fix bazelbuild#15762 and bazelbuild#15865 (if they depend on windows).

Linked to 08936ae

Closes bazelbuild#16694.

PiperOrigin-RevId: 505084880
Change-Id: Ie4dc08a0e93c76419b6164bacccadac32a7c7b2f
@lripoche lripoche mentioned this issue Apr 20, 2023
Closed
@lripoche lripoche mentioned this issue Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-CPP Issues for C++ rules type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add external_include_paths feature on windows cpp toolchain lripoche/bazel
5 participants
@meteorcloudy @lripoche @qchenzi @oquenchil @sgowroji