Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and re-enable //src/test/shell/bazel/android:* tests #18776

Closed
fweikert opened this issue Jun 26, 2023 · 5 comments
Closed

Fix and re-enable //src/test/shell/bazel/android:* tests #18776

fweikert opened this issue Jun 26, 2023 · 5 comments
Assignees
@ted-xie
Labels
P1 I'll work on this now. (Assignee required) team-Android Issues for Android team type: bug

Comments

@fweikert
Copy link
Member

fweikert commented Jun 26, 2023 •
edited
Loading

Description of the bug:

Affected tests:

  • //src/test/shell/bazel/android:android_instrumentation_test_integration_test*
  • //src/test/shell/bazel/android:aapt_integration_test*

For some reason these tests insist on using Python 2, thus failing with newer versions of abseil: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/16018#018857ff-07d5-4df7-bcfa-39cf418a58f4

(More context can be found in #16526)

I'm going to disable these tests for now since they block other work (#18497)
@fweikert fweikert changed the title Fix and re-enable //src/test/shell/bazel/android:android_instrumentation_test_integration_test* tests Fix and re-enable //src/test/shell/bazel/android:* tests Jun 26, 2023
copybara-service bot pushed a commit that referenced this issue Jun 26, 2023
@fweikert @copybara-github
Bazel CI: Temporarily disable Android shell tests.
68f6126 
These tests are incompatible with Python 3 environments.

This change unblocks #18497.
The tests should be fixed and re-enabled, tracked in #18776

PiperOrigin-RevId: 543491138
Change-Id: Id7faa248a7b57c3d645216bdba98c54534b06217
@iancha1992 iancha1992 added the team-Android Issues for Android team label Jun 26, 2023
@fweikert fweikert added P1 I'll work on this now. (Assignee required) and removed untriaged labels Jun 27, 2023
katre added a commit to katre/bazel that referenced this issue Nov 28, 2023
@katre
Re-enable Android tests.
d985e61 
These tests were disabled as part of bazelbuild#18776.
@katre
Copy link
Member

katre commented Nov 28, 2023

I tried re-enabling these (after some other cleanups), and the python failures only happen in the Centos 7 builders, so I assume this is a problem on those where python 2 is the default, instead of python 3.

I'll take a look and see if there is anything obvious to do.

@katre
Copy link
Member

katre commented Nov 28, 2023

Sorry, #20348 is the PR and https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/18656 is the test run.

@katre
Copy link
Member

katre commented Nov 28, 2023

Yup:

$ docker run -it gcr.io/bazel-public/centos7-java11-devtoolset10:latest bash
Unable to find image 'gcr.io/bazel-public/centos7-java11-devtoolset10:latest' locally
latest: Pulling from bazel-public/centos7-java11-devtoolset10
Digest: sha256:f335a5d84d385e95bd736abdfb2115fe368a7bd7993da15f833cdec6541edf5f
Status: Downloaded newer image for gcr.io/bazel-public/centos7-java11-devtoolset10:latest
[root@2c7017cf9f55 /]# which python
/usr/bin/python
[root@2c7017cf9f55 /]# python --version
Python 2.7.5

@katre katre mentioned this issue Nov 28, 2023
Closed
katre added a commit to katre/bazel that referenced this issue Nov 28, 2023
@katre
Re-enable Android tests.
1198d98 
These tests were disabled as part of bazelbuild#18776.
katre added a commit to katre/bazel that referenced this issue Nov 29, 2023
@katre
Re-enable Android tests.
ce7c891 
These tests were disabled as part of bazelbuild#18776.
@katre katre mentioned this issue Nov 29, 2023
Closed
@katre
Copy link
Member

katre commented Nov 29, 2023

Okay, I'm going to re-enable the tests for everything except centos7. I may take time to debug the issue there but it's lower priority as long as there is some coverage.

Even after bazelbuild/continuous-integration#1823 the tests are using python 2 so I'm a bit confused.

copybara-service bot pushed a commit that referenced this issue Dec 4, 2023
@katre @copybara-github
Re enable android tests
5232ab2 
Work towards #18776.

Centos tests are still disabled because of python version issues: #18776 (comment)

Closes #20348.

PiperOrigin-RevId: 587674122
Change-Id: Id99b09d9dc184f015f02e4ebc921dcfa58adcc45
katre added a commit to katre/bazel that referenced this issue Dec 5, 2023
@katre
Re-diable android_instrumentation_test_integration_test on macOS.
ea38476 
Still seeing problems with finding python: https://buildkite.com/bazel/bazel-bazel/builds/25852#018c37b0-3cb4-4829-826b-eced53b34e5f

Part of bazelbuild#20437 and bazelbuild#18776.
@katre katre mentioned this issue Dec 5, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Dec 5, 2023
@katre @copybara-github
Re-disable android_instrumentation_test_integration_test on macOS.
e075872 
Still seeing problems with finding python: https://buildkite.com/bazel/bazel-bazel/builds/25852#018c37b0-3cb4-4829-826b-eced53b34e5f

Part of #20437 and #18776.

Closes #20440.

PiperOrigin-RevId: 588180701
Change-Id: I8a0181f96df7612c72ce5e33336690f3a0efef15
Wyverald pushed a commit that referenced this issue Jan 3, 2024
@katre @Wyverald
Re enable android tests
7ae32f3 
Work towards #18776.

Centos tests are still disabled because of python version issues: #18776 (comment)

Closes #20348.

PiperOrigin-RevId: 587674122
Change-Id: Id99b09d9dc184f015f02e4ebc921dcfa58adcc45
Wyverald pushed a commit that referenced this issue Jan 3, 2024
@katre @Wyverald
Re-disable android_instrumentation_test_integration_test on macOS.
498209d 
Still seeing problems with finding python: https://buildkite.com/bazel/bazel-bazel/builds/25852#018c37b0-3cb4-4829-826b-eced53b34e5f

Part of #20437 and #18776.

Closes #20440.

PiperOrigin-RevId: 588180701
Change-Id: I8a0181f96df7612c72ce5e33336690f3a0efef15
copybara-service bot pushed a commit that referenced this issue Feb 21, 2024
@meteorcloudy @copybara-github
Improve test coverage on macOS
e46f3d1 
- Add `--test_tag_filters=-no_macos` for macOS to filter out tests that are not suppose to run on Mac, just like the `no_windows` tag.
- Fixed PatchApiBlackBoxTest and GitRepositoryBlackBoxTest on newer macOS versions.
- Enable previously disabled tests on arm64 macOS platform in presubmit
- Disable slow tests on Intel macOS platform in presubmit since they are often the bottleneck.

Tests fixed:

- Fixes #16525
- Fixes #17447
- Fixes #17411
- Related: #18776 (fixed on macos_arm64)

Closes #21381.

PiperOrigin-RevId: 608993052
Change-Id: I03bdf954c358bb736a866ce3a02f6dac4473e47e
meteorcloudy added a commit to meteorcloudy/bazel that referenced this issue Feb 21, 2024
@meteorcloudy
Improve test coverage on macOS
9f3f465 
- Add `--test_tag_filters=-no_macos` for macOS to filter out tests that are not suppose to run on Mac, just like the `no_windows` tag.
- Fixed PatchApiBlackBoxTest and GitRepositoryBlackBoxTest on newer macOS versions.
- Enable previously disabled tests on arm64 macOS platform in presubmit
- Disable slow tests on Intel macOS platform in presubmit since they are often the bottleneck.

Tests fixed:

- Fixes bazelbuild#16525
- Fixes bazelbuild#17447
- Fixes bazelbuild#17411
- Related: bazelbuild#18776 (fixed on macos_arm64)

Closes bazelbuild#21381.

PiperOrigin-RevId: 608993052
Change-Id: I03bdf954c358bb736a866ce3a02f6dac4473e47e
@meteorcloudy
Copy link
Member

We are not going to fix those tests since we are moving out android rules from Bazel

@meteorcloudy meteorcloudy closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ted-xie ted-xie

Labels
P1 I'll work on this now. (Assignee required) team-Android Issues for Android team type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@katre @meteorcloudy @ted-xie @fweikert @sgowroji @Pavank1992 @iancha1992 and others