Add test coverage support to android_local_test #15840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagakov
approved these changes
Jul 8, 2022
sgowroji
added
the
awaiting-review
Bencodes
force-pushed
the
add-test-coverage-support-to-android_local_test
branch
4 times, most recently
from
aed7f1c
to
2638341
Compare
ted-xie
requested changes
Jul 13, 2022
|
|
||
| # Asserts that the coverage file exists by looking at the current $TEST_log. | ||
| # The method fails if TEST_log does not contain any coverage report for a passed test. | ||
| function assert_coverage_file_exists() { |
There was a problem hiding this comment.
Perhaps it would be prudent to assert that the contents of the coverage dat file are valid? Even asserting that there is at least 1 row in the file would be sufficient: [[ $(wc -l $coverage_file_path) -gt 0 ]] || fail "Insufficient data in coverage data file $coverage_file_path"
There was a problem hiding this comment.
Updated with some additional test cases around coverage contents and lcov merging contents.
There was a problem hiding this comment.
It looks like there were some Windows-related failures in the latest presubmit; any idea about those?
There was a problem hiding this comment.
@ted-xie everything should be passing. The windows failures were build flakes.
Bencodes
force-pushed
the
add-test-coverage-support-to-android_local_test
branch
from
1d421f7
to
c7ea2f0
Compare
Bencodes
force-pushed
the
add-test-coverage-support-to-android_local_test
branch
from
c7ea2f0
to
3f10bf3
Compare
Bencodes
force-pushed
the
add-test-coverage-support-to-android_local_test
branch
from
3f10bf3
to
e56b644
Compare
|
@sofiethorsen thanks for pinging me. I think we should merge this in. |
ted-xie
approved these changes
Feb 8, 2023
ted-xie
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
ted-xie
pushed a commit
to ted-xie/bazel
that referenced
this pull request
Feb 10, 2023
Adding test coverage support to `android_local_test`. bazelbuild#15827 Closes bazelbuild#15840. RELNOTES: Adds coverage metric support to android_local_test PiperOrigin-RevId: 508549884 Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185
ted-xie
pushed a commit
to ted-xie/bazel
that referenced
this pull request
Feb 23, 2023
Adding test coverage support to `android_local_test`. bazelbuild#15827 Closes bazelbuild#15840. RELNOTES: Adds coverage metric support to android_local_test PiperOrigin-RevId: 508549884 Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185
|
@bazel-io fork 6.1.0 |
ted-xie
pushed a commit
to ted-xie/bazel
that referenced
this pull request
Mar 1, 2023
Adding test coverage support to `android_local_test`. bazelbuild#15827 Closes bazelbuild#15840. RELNOTES: Adds coverage metric support to android_local_test PiperOrigin-RevId: 508549884 Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185
ted-xie
pushed a commit
to ted-xie/bazel
that referenced
this pull request
Mar 1, 2023
Adding test coverage support to `android_local_test`. bazelbuild#15827 Closes bazelbuild#15840. RELNOTES: Adds coverage metric support to android_local_test PiperOrigin-RevId: 508549884 Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185
ted-xie
pushed a commit
to ted-xie/bazel
that referenced
this pull request
Mar 13, 2023
Adding test coverage support to `android_local_test`. bazelbuild#15827 Closes bazelbuild#15840. RELNOTES: Adds coverage metric support to android_local_test PiperOrigin-RevId: 508549884 Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185
ShreeM01
added a commit
that referenced
this pull request
Mar 13, 2023
* Propagate runfiles for singlejar. Since the singlejar toolchain attribute is currently defined as a single file and carried around as an Artifact instead of a FilesToRunProvider, it's not possible to implement it as a wrapper script that dispatches to an actual implementation somewhere in its runfiles. This would be useful to experiment with cross-platform action sharing. PiperOrigin-RevId: 492487124 Change-Id: Ib0f80314eae09bd865b3f31a4180bf068833cdf4 * Add test coverage support to android_local_test Adding test coverage support to `android_local_test`. #15827 Closes #15840. RELNOTES: Adds coverage metric support to android_local_test PiperOrigin-RevId: 508549884 Change-Id: I6977efa51ca1c7a6df1f776fe1a326d07989a185 --------- Co-authored-by: Googler <tjgq@google.com> Co-authored-by: Benjamin Lee <ben@ben.cm> Co-authored-by: kshyanashree <109167932+kshyanashree@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test coverage support to
android_local_test.#15827