Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.1.0]Add --host_features #17503

Closed
wants to merge 4 commits into from
Closed

[6.1.0]Add --host_features #17503

wants to merge 4 commits into from

Conversation

ShreeM01
Copy link
Contributor

Previously there was no way to have a feature only apply to the entire transitive target closure without --features which also applied to the host / exec configuration. This is undesirable for many features such as C++ sanitizers where you often only need them to affect targets in the target configuration, and you don't want to invalidate all host tools when switching between these build configurations.

RELNOTES[INC]: --features only applies to targets built in the target configuration, and --host_features is used for the host / exec configuration (gated behind --incompatible_use_host_features)

Fixes #13839

Closes #16626.

PiperOrigin-RevId: 509809427
Change-Id: I3fadb1e28267c096a25d8841648175306ee73f2e

Previously there was no way to have a feature only apply to the entire transitive target closure without `--features` which also applied to the host / exec configuration. This is undesirable for many features such as C++ sanitizers where you often only need them to affect targets in the target configuration, and you don't want to invalidate all host tools when switching between these build configurations.

RELNOTES[INC]: `--features` only applies to targets built in the target configuration, and `--host_features` is used for the host / exec configuration (gated behind `--incompatible_use_host_features`)

Fixes #13839

Closes #16626.

PiperOrigin-RevId: 509809427
Change-Id: I3fadb1e28267c096a25d8841648175306ee73f2e
@ShreeM01 ShreeM01 requested review from oquenchil and removed request for oquenchil February 15, 2023 19:23
@sgowroji sgowroji added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Feb 16, 2023
@ShreeM01 ShreeM01 closed this Feb 17, 2023
@ShreeM01 ShreeM01 reopened this Feb 17, 2023
@ShreeM01
Copy link
Contributor Author

Hi @keith, Above presubmits are getting failed after Cherry-picking. Could you please look into it? Thanks!

@keith
Copy link
Member

keith commented Feb 17, 2023

@kshyanashree here you go #17528, it was just a exec -> host issue

@ShreeM01
Copy link
Contributor Author

@kshyanashree here you go #17528, it was just a exec -> host issue

Yeah @keith! I did check that. Thanks for the new PR.

@keertk
Copy link
Member

keertk commented Feb 19, 2023

New PR - #17528
Closing this one.

@keertk keertk closed this Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants