Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply exec transition to lcov_merger in sh_test and cc_test #17631

Closed
wants to merge 2 commits into from
Closed

Apply exec transition to lcov_merger in sh_test and cc_test #17631

wants to merge 2 commits into from

Conversation

thirtyseven
Copy link
Contributor

Fixes #17630

@sgowroji sgowroji added team-Rules-Server Issues for serverside rules included with Bazel awaiting-review PR is awaiting review from an assigned reviewer labels Mar 1, 2023
@thirtyseven
Copy link
Contributor Author

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Mar 1, 2023
@thirtyseven thirtyseven mentioned this pull request Mar 1, 2023
Merged
@thirtyseven thirtyseven changed the title Apply exec transition to lcov_merger in sh_test Apply exec transition to lcov_merger in sh_test and cc_test Mar 1, 2023
@thirtyseven
Copy link
Contributor Author

I've searched the bazel codebase for the string attr(":lcov_merger" and these were the last two instances that were missing the exec transition.

@thirtyseven
Copy link
Contributor Author

cc @c-mita

c-mita
c-mita approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@c-mita c-mita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cc_test it doesn't really matter; the rule has been implemented in Starlark and the Java only exists for documentation purposes now.

But I'll approve for the sake of sh_test.

@c-mita c-mita added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Mar 1, 2023
@copybara-service copybara-service bot closed this in 37953c5 Mar 1, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 1, 2023
@ShreeM01
Copy link
Contributor

ShreeM01 commented Mar 2, 2023

@bazel-io fork 6.1.0

@bazel-io bazel-io mentioned this pull request Mar 2, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Mar 2, 2023
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@thirtyseven @fweikert
Apply exec transition to lcov_merger in sh_test and cc_test
66bee49 
Fixes bazelbuild#17630

Closes bazelbuild#17631.

PiperOrigin-RevId: 513254952
Change-Id: Id97892db8adca0d8bbb5ecd87a44e3f711a5b56c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-mita c-mita c-mita approved these changes

Assignees
No one assigned
Labels
team-Rules-Server Issues for serverside rules included with Bazel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exec transition is missing on lcov_merger in sh_test and cc_test
5 participants
@thirtyseven @ShreeM01 @c-mita @bazel-io @sgowroji