This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Silence go module warnings in go_repository #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [x] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? When executing the repository rule `com_github_google_go_containerregistry`, the following warning is printed: ``` DEBUG: /private/var/tmp/_bazel_martin/37de97fe4a6bb79f99ddaabf4bd12042/external/bazel_gazelle/internal/go_repository.bzl:184:18: com_github_google_go_containerregistry: gazelle: finding module path for import github.com/vdemeester/k8s-pkg-credentialprovider: exit status 1: go: finding module for package github.com/vdemeester/k8s-pkg-credentialprovider go: found github.com/vdemeester/k8s-pkg-credentialprovider in github.com/vdemeester/k8s-pkg-credentialprovider v1.21.0 go: github.com/vdemeester/k8s-pkg-credentialprovider@v1.21.0 requires k8s.io/kubelet@v0.0.0: reading k8s.io/kubelet/go.mod at revision v0.0.0: unknown revision v0.0.0 gazelle: finding module path for import github.com/vdemeester/k8s-pkg-credentialprovider: exit status 1: go: finding module for package github.com/vdemeester/k8s-pkg-credentialprovider go: found github.com/vdemeester/k8s-pkg-credentialprovider in github.com/vdemeester/k8s-pkg-credentialprovider v1.21.0 go: github.com/vdemeester/k8s-pkg-credentialprovider@v1.21.0 requires k8s.io/kubelet@v0.0.0: reading k8s.io/kubelet/go.mod at revision v0.0.0: unknown revision v0.0.0 gazelle: finding module path for import github.com/vdemeester/k8s-pkg-credentialprovider: exit status 1: go: finding module for package github.com/vdemeester/k8s-pkg-credentialprovider go: found github.com/vdemeester/k8s-pkg-credentialprovider in github.com/vdemeester/k8s-pkg-credentialprovider v1.21.0 go: github.com/vdemeester/k8s-pkg-credentialprovider@v1.21.0 requires k8s.io/kubelet@v0.0.0: reading k8s.io/kubelet/go.mod at revision v0.0.0: unknown revision v0.0.0 gazelle: finding module path for import github.com/vdemeester/k8s-pkg-credentialprovider: exit status 1: go: finding module for package github.com/vdemeester/k8s-pkg-credentialprovider go: found github.com/vdemeester/k8s-pkg-credentialprovider in github.com/vdemeester/k8s-pkg-credentialprovider v1.21.0 go: github.com/vdemeester/k8s-pkg-credentialprovider@v1.21.0 requires k8s.io/kubelet@v0.0.0: reading k8s.io/kubelet/go.mod at revision v0.0.0: unknown revision v0.0.0 gazelle: finding module path for import github.com/vdemeester/k8s-pkg-credentialprovider: exit status 1: go: finding module for package github.com/vdemeester/k8s-pkg-credentialprovider go: found github.com/vdemeester/k8s-pkg-credentialprovider in github.com/vdemeester/k8s-pkg-credentialprovider v1.21.0 go: github.com/vdemeester/k8s-pkg-credentialprovider@v1.21.0 requires k8s.io/kubelet@v0.0.0: reading k8s.io/kubelet/go.mod at revision v0.0.0: unknown revision v0.0.0 gazelle: finding module path for import k8s.io/client-go/kubernetes: exit status 1: go: finding module for package k8s.io/client-go/kubernetes module k8s.io/client-go@latest found (v1.5.2), but does not contain package k8s.io/client-go/kubernetes gazelle: finding module path for import k8s.io/client-go/rest: exit status 1: go: finding module for package k8s.io/client-go/rest module k8s.io/client-go@latest found (v1.5.2), but does not contain package k8s.io/client-go/rest gazelle: finding module path for import k8s.io/client-go/kubernetes: exit status 1: go: finding module for package k8s.io/client-go/kubernetes module k8s.io/client-go@latest found (v1.5.2), but does not contain package k8s.io/client-go/kubernetes ``` The `github.com/vdemeester/k8s-pkg-credentialprovider` package is used by `github.com/google/go-containerregistry/pkg/authn/k8schain`, but [`k8schain`](https://github.com/google/go-containerregistry/tree/main/pkg/authn/k8schain) itself is not used by `rules_docker`. In fact, afaict `k8schain` was spun off into its own module so that `go-containerregistry` wouldn't have to vendor k8s. ## What is the new behavior? No warnings printed. Build targets are also not generated for the `k8schain` package, however this is should be okay as it is not used by `rules_docker` and not likely to be used as it contains a rather heavy dependency on the k8s client. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information
martinxsliu
requested review from
alexeagle,
gravypod,
pcj and
smukherj1
as code owners
pcj
approved these changes
Jul 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When executing the repository rule
com_github_google_go_containerregistry, the following warning is printed:The
github.com/vdemeester/k8s-pkg-credentialproviderpackage is used bygithub.com/google/go-containerregistry/pkg/authn/k8schain, butk8schainitself is not used byrules_docker. In fact, afaictk8schainwas spun off into its own module so thatgo-containerregistrywouldn't have to vendor k8s.What is the new behavior?
No warnings printed. Build targets are also not generated for the
k8schainpackage, however this is should be okay as it is not used byrules_dockerand not likely to be used as it contains a rather heavy dependency on the k8s client.Does this PR introduce a breaking change?
Other information
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information