Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uploading large files saving to disk instead of memory #4935

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming me@frostming.com

What does this PR address?

Fixes #(issue)

Before submitting:

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming requested a review from a team as a code owner August 23, 2024 06:03
@frostming frostming requested review from bojiang, sauyon and aarnphm and removed request for a team August 23, 2024 06:03
@sauyon
Copy link
Contributor

sauyon commented Aug 23, 2024

I think there is a separate issue with building large Bentos on Linux (I think we do actually use temp directory for building?), so I can't test this, but LGTM otherwise.

@frostming
Copy link
Contributor Author

frostming commented Aug 23, 2024

I think there is a separate issue with building large Bentos on Linux (I think we do actually use temp directory for building?), so I can't test this, but LGTM otherwise.

Yes, let's improve it later. Because usually the bento won't be too large, it is not urgent.

Signed-off-by: Frost Ming <me@frostming.com>
@bojiang
Copy link
Member

bojiang commented Aug 23, 2024

Tested with 15G models. The speed is acceptable.

@frostming frostming merged commit ed13a97 into bentoml:main Aug 23, 2024
46 of 51 checks passed
@frostming frostming deleted the fix/upload-large-file branch August 23, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants