GitHub gradle.yml workflow: use JDK 23 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our Gradle wrapper is already using Gradle 8.10, so JDK 23 is supported. Use `-PjavaToolchainVersion=23` on the Gradle command line in gradle.yml and leave the default value of javaToolchainVersion=22 (gradle.properties) for people using Nix or other environments that don't have JDK 23 available yet. Update secp-examples-*/build.gradle to use javaToolchainVersion when configuring toolchains.
schildbach
approved these changes
Sep 20, 2024
The default is JDK 22, the command-line flag can override. So the behavior doesn't change by environment but by a command-line flag. But I get your point.
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Gradle wrapper is already using Gradle 8.10, so JDK 23 is supported.
Use
-PjavaToolchainVersion=23on the Gradle command line in gradle.yml and leave the default value of javaToolchainVersion=22 (gradle.properties) for people using Nix or other environments that don't have JDK 23 available yet.Update secp-examples-*/build.gradle to use javaToolchainVersion when configuring toolchains.