[PM-10607] Require userId for getKeyForCipherKeyDecryption #10509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acySupport and use the version that requires a user id
|
New Issues
|
gbubemismith
requested review from
dani-garcia,
r-tome,
LRNcardozoWDF,
jlf0dev,
shane-melton and
justindbaur
and removed request for
dani-garcia
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #10509 +/- ##
==========================================
- Coverage 32.83% 32.79% -0.05%
==========================================
Files 2670 2670
Lines 81596 81769 +173
Branches 15381 15414 +33
==========================================
+ Hits 26794 26816 +22
- Misses 52745 52877 +132
- Partials 2057 2076 +19 ☔ View full report in Codecov by Sentry. |
JaredSnider-Bitwarden
previously approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Non blocking informational: In case you didn't know, there is a nice helper function called mockAccountServiceWith(...) which makes it easy to mock AccountService context without having to stand up your own active account observable.
cagonzalezcs
previously approved these changes
Aug 14, 2024
justindbaur
previously approved these changes
Aug 14, 2024
shane-melton
requested changes
Aug 14, 2024
gbubemismith
dismissed stale reviews from justindbaur and cagonzalezcs
via
4410ae9
gbubemismith
requested review from
justindbaur,
cagonzalezcs,
shane-melton and
audreyality
JaredSnider-Bitwarden
previously approved these changes
Aug 20, 2024
r-tome
previously approved these changes
Aug 20, 2024
cagonzalezcs
previously approved these changes
Aug 20, 2024
justindbaur
previously approved these changes
Aug 20, 2024
audreyality
previously approved these changes
Aug 20, 2024
gbubemismith
dismissed stale reviews from audreyality, justindbaur, cagonzalezcs, r-tome, and JaredSnider-Bitwarden
via
05cbd23
gbubemismith
requested review from
JaredSnider-Bitwarden,
r-tome,
cagonzalezcs and
audreyality
audreyality
approved these changes
Aug 20, 2024
JaredSnider-Bitwarden
approved these changes
Aug 20, 2024
justindbaur
approved these changes
Aug 20, 2024
shane-melton
approved these changes
Aug 20, 2024
cagonzalezcs
approved these changes
Aug 20, 2024
vincentsalucci
approved these changes
Aug 20, 2024
cagonzalezcs
pushed a commit
that referenced
this pull request
Aug 22, 2024
* updated cipher service to stop using the deprecated getUserKeyWithLegacySupport and use the version that requires a user id * Added account service mock * fixed cipher test * Fixed test * removed async from encryptCipher * updated encryptSharedCipher to pass userId to the encrypt function * Pass userId to getUserKeyWithLegacySupport on encryptSharedCipher * pass in userid when setting masterKeyEncryptedUserKey * Added activer usedId to new web refresh function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-10607
📔 Objective
Due to recent reports from some users getting "Error: Must provide key", a potential resolution for this is to stop using the deprecated version of
getUserKeyWithLegacySupportin thegetKeyForCipherKeyDecryptionfunction and instead requireuserIdto be passed down from components or services.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes