Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LLVM12 static linkage #225

Closed
njamb94 opened this issue Jan 9, 2024 · 1 comment · Fixed by #234
Closed

Add support for LLVM12 static linkage #225

njamb94 opened this issue Jan 9, 2024 · 1 comment · Fixed by #234

Comments

@njamb94
Copy link

njamb94 commented Jan 9, 2024

Hello,

On Linux 22.04, at the moment, it is not possible to statically link LLVM12 due to clangSupport library in LLVMSetup.cmake file. (See make output: link_llvm12_static.log)

From my point of view, the fix lies in modifying LLVMSetup.cmake file to exclude clangSupport library if LLVM version is bellow 15 (like it is done for MSVC):
link_llvm12_static_fix

The choice for llvm static linkage was done by modifying options in CMakeLists.txt:
option_link_llvm_shared_off

Question: would it make more sense to make llvm linkage type configurable from the Makefile?
Something like this:
makefile_duse_shared_llvm

@bkryza
Copy link
Owner

bkryza commented Jan 9, 2024

@njamb94 I'll look into this, I'll have to check how this affects macos and MSVC targets.

bkryza added a commit that referenced this issue Jan 28, 2024
bkryza added a commit that referenced this issue Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants