Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust gas-costs for EIP-2935 BLOCKHASH #1422

Merged
merged 1 commit into from
May 16, 2024

Conversation

DaniPopes
Copy link
Collaborator

Don't pay for SLOAD.

Ref ethereum/EIPs#8564

Copy link
Collaborator

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - onbjerg

@DaniPopes
Copy link
Collaborator Author

ty boss

@DaniPopes DaniPopes merged commit 6e81b88 into bluealloy:main May 16, 2024
25 checks passed
@DaniPopes DaniPopes deleted the eip2935-gas branch May 16, 2024 13:41
@github-actions github-actions bot mentioned this pull request May 16, 2024
let Some((value, _)) = host.sload(BLOCKHASH_STORAGE_ADDRESS, index) else {
interpreter.instruction_result = InstructionResult::FatalExternalError;
return;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this okay, it will warm load the storage?

This was referenced May 17, 2024
This was referenced Jun 3, 2024
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants