Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip tests with storage check and return status #1452

Merged
merged 5 commits into from
May 24, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented May 24, 2024

Test that have storage empty check are skipped.

Returns executable status so CI can properly fail.

Copy link
Contributor

github-actions bot commented May 24, 2024

Valgrind Results:

==3893== Cachegrind, a cache and branch-prediction profiler
==3893== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3893== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3893== Command: target/release/snailtracer
==3893== 
--3893-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.815903485s
==3893== 
==3893== I   refs:      429,371,833
==3893== I1  misses:          3,118
==3893== LLi misses:          2,801
==3893== I1  miss rate:        0.00%
==3893== LLi miss rate:        0.00%
==3893== 
==3893== D   refs:      206,205,188  (133,650,687 rd   + 72,554,501 wr)
==3893== D1  misses:        344,948  (    204,872 rd   +    140,076 wr)
==3893== LLd misses:        137,606  (      4,256 rd   +    133,350 wr)
==3893== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3893== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3893== 
==3893== LL refs:           348,066  (    207,990 rd   +    140,076 wr)
==3893== LL misses:         140,407  (      7,057 rd   +    133,350 wr)
==3893== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit 0e1cd99 into main May 24, 2024
24 checks passed
@rakita rakita deleted the rakita/skip_storage_check_tests branch June 1, 2024 12:54
This was referenced Jun 3, 2024
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant