Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op): Remove UintTryFrom<{float}> dep in l1block module #1498

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

clabby
Copy link
Contributor

@clabby clabby commented Jun 8, 2024

Overview

Specifies the type of 1e12 as u64 in the l1block.rs module, rather than a float literal, removing the need for UintTryFrom<{float}>. Certain environments, like the OP Stack's fault proof VMs, do not support floating point arithmetic.

Specifies the type of `1e12` as `u64` in the `l1block.rs` module,
removing the need for `UintTryFrom<{float}>`.
@rakita rakita merged commit a832a4e into bluealloy:main Jun 8, 2024
25 checks passed
@clabby clabby deleted the cl/float-rm branch June 8, 2024 17:33
This was referenced Jun 8, 2024
This was referenced Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants