-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use const blocks #1522
chore: use const blocks #1522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need msrv bump?
Revm has no MSRV, but yes it would be a bump from 1.75 (I just tried |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Will publish a new version of revm soon, so I will merge this PR after this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Failed tests not related |
const {}
blocks were stabilized yesterday as part of 1.79.I would've liked to make the instruction table
&'static
but unfortunately that requiresH: 'static
even if it's through a function pointer.