Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: store tokio::runtime::Handle in ethers/alloyDB #1557

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

chirag-bgh
Copy link
Contributor

ref #1534

Copy link
Collaborator

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also return None if the runtime flavor is CurrentThread, and can you document it briefly in the fn new doc comments saying that it requires a tokio runtime?

otherwise looks good

crates/revm/src/db/ethersdb.rs Outdated Show resolved Hide resolved
@rakita rakita merged commit b40e4e3 into bluealloy:main Jun 28, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
@wtdcode
Copy link
Contributor

wtdcode commented Jun 28, 2024

@rakita This change is not appropriate. If you wish to enforce ethersdb/alloydb to always play with async world, you should mark fn new as async fn new even not using any await in the function. This removes the check and also presents the correct signature.

@DaniPopes I disagree with not allowing ethersdb/alloydb to create current thread runtime. This makes them totally incompatible with sync world and creating a current thread runtime is rather cheap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants