feat: Introduce ByteCode format #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
reviewed
Jul 31, 2022
| pub first_gas_block: u32, | ||
| /// Rc is used here so that we dont need to copy vector. We can move it to more suitable more accessable structure | ||
| /// without copying underlying vec. | ||
| pub analysis: Rc<Vec<AnalysisData>>, |
There was a problem hiding this comment.
Can we make this an Arc? Forge has some shared backend logic that sends AccountInfo across thread bounds and the Rc makes it !Send 😄
|
|
||
| #[derive(Clone, Debug)] | ||
| #[cfg_attr(feature = "with-serde", derive(serde::Serialize, serde::Deserialize))] | ||
| pub struct Bytecode { |
There was a problem hiding this comment.
Can we get Eq and PartialEq?
Closed
This was referenced Feb 8, 2024
Merged
This was referenced Feb 16, 2024
Closed
Merged
This was referenced Feb 24, 2024
Merged
This was referenced Mar 12, 2024
This was referenced Mar 22, 2024
Closed
Closed
Closed
Merged
This was referenced Apr 2, 2024
Merged
This was referenced Apr 16, 2024
This was referenced May 2, 2024
Closed
This was referenced May 13, 2024
Closed
Closed
Closed
Closed
This was referenced Sep 9, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #121