Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor code, and check if precompile for create collision #1600

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Jul 10, 2024

warm_preloaded_addresses was used for create collision check. That made sense when it was the list of precompile addresses but with new usage, this is incorrect.

Moves creating of frame from inner context to Context.

Copy link
Contributor

Valgrind Results:

==3929== Cachegrind, a cache and branch-prediction profiler
==3929== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3929== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3929== Command: target/release/snailtracer
==3929== 
--3929-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.846842386s
==3929== 
==3929== I   refs:      427,041,759
==3929== I1  misses:          5,377
==3929== LLi misses:          2,840
==3929== I1  miss rate:        0.00%
==3929== LLi miss rate:        0.00%
==3929== 
==3929== D   refs:      204,077,726  (132,269,195 rd   + 71,808,531 wr)
==3929== D1  misses:        340,222  (    200,215 rd   +    140,007 wr)
==3929== LLd misses:        137,818  (      4,498 rd   +    133,320 wr)
==3929== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3929== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3929== 
==3929== LL refs:           345,599  (    205,592 rd   +    140,007 wr)
==3929== LL misses:         140,658  (      7,338 rd   +    133,320 wr)
==3929== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit 929d4b2 into main Jul 10, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request Jul 16, 2024
@rakita rakita deleted the rakita/precompile_create_collision branch July 16, 2024 23:20
j75689 pushed a commit to j75689/revm that referenced this pull request Aug 1, 2024
…luealloy#1600)

* chore: Refactor code, and check is precompile for create colision

* remove some TODOs for eofcreate nonce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant