rfc: Lazy-load fee beneficiary in mainnet handler #1774
Conversation
clabby
force-pushed
the
cl/lazyload-beneficiaries-op
branch
from
bdeb8df
to
6155ebc
Compare
clabby
changed the title
| let basefee = *context.evm.env.block.basefee(); | ||
|
|
||
| // Skip the transfer if basefee and max priority fee per gas is zero, like geth. | ||
| if basefee.is_zero() |
There was a problem hiding this comment.
Why do we skip if basefee is zero? Shouldn't we skip only if coinbase_gas_price == 0
There was a problem hiding this comment.
It looks like that's geth's heuristic, just tried to do the same: https://github.com/ethereum/go-ethereum/blob/ae707445f54972f4fddc7c6cf8ba2de083636e50/core/state_transition.go#L468
| @@ -49,11 +66,7 @@ pub fn reward_beneficiary<EvmWiringT: EvmWiring, SPEC: Spec>( | |||
| .map_err(EVMError::Database)?; | |||
|
|
|||
| coinbase_account.data.mark_touch(); | |||
There was a problem hiding this comment.
We are skipping touch on coinbase account.
Geth code looks like a edge case:
https://github.com/ethereum/go-ethereum/blob/ae707445f54972f4fddc7c6cf8ba2de083636e50/core/state/state_object.go#L452-L459
This can potentially be a bug for EIP-161 State clear. The trigger is if coinbase is empty_account (Created before EIP-161) and there is no fee for this tx.
|
Going to go ahead and close this for the time being - will re-visit as we start to work on standardizing the execution witnesses generated by |
Overview
Lazy-loads the fee beneficiaries like
geth's EVM does. In the case where no value is transferred to the fee beneficiary, the account is not actually loaded from state ingeth. This is a small semantic difference between the two implementations that does not actually affect the outcome of the STF, but does make execution witnesses generated bygethincompatible withrethdue to the lack of a MPT proof for the fee beneficiary account.Because
load_accounthits the DB viaDatabase::basic, a proof to the beneficiary account in the trie is required to complete execution.This edge case shows up in empty L1/L2 blocks, specifically for the 4788 transaction, where
gas_price == 0, no value is transferred, and no other transactions load the fee recipient.Note that the fee recipients on Optimism are always loaded, so that logic remains untouched: https://github.com/ethereum-optimism/op-geth/blob/21010bb6b78b8478ff0121778b781411263e160d/core/state_transition.go#L585-L597
Refs
https://github.com/ethereum/go-ethereum/blob/ae707445f54972f4fddc7c6cf8ba2de083636e50/core/state_transition.go#L468-L471